Properly validate JS->native method calls#23658
Closed
aleclarson wants to merge 1 commit intofacebook:masterfrom
Closed
Properly validate JS->native method calls#23658aleclarson wants to merge 1 commit intofacebook:masterfrom
aleclarson wants to merge 1 commit intofacebook:masterfrom
Conversation
facebook-github-bot
added
the
CLA Signed
hramos
referenced
this pull request
Feb 26, 2019
…id bridge Summary: A bunch of flows including JS reload and e2e tests seem to hit the race condition, causing redbox. For now, make it a warning to unblock. Differential Revision: D9327418 fbshipit-source-id: a72b378d88f7566268fd9415fbd34225c8b931e7
fkgozali
reviewed
Feb 27, 2019
fkgozali
reviewed
Feb 27, 2019
Contributor
Author
|
I've removed the warning entirely, in favor of silently ignoring method calls with no method queue. The |
Contributor
|
I would prefer to have a warning, even just in dev mode. We’ve seen things like this happen when there’s memory corruption issues within JSC or CxxReact. Being able to catch the first symptoms earlier so a dump can be created and analyzed would help. |
Between invalidating a bridge and suspending its JS thread, native modules may have their methods called. Only warn when a native module has been invalidated, which happens right before its JS thread is suspended. Avoid initializing a native module's instance if its bridge is invalidated.
Contributor
Author
|
@matthargett Okay, fixed. |
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@fkgozali has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
matthargett
approved these changes
Mar 2, 2019
facebook-github-bot
added
the
Import Started
Collaborator
|
This pull request was successfully merged by @aleclarson in dc89375. When will my fix make it into a release? | Upcoming Releases |
react-native-bot
added
Merged
calebmer
pushed a commit
to calebmer/react-native
that referenced
this pull request
May 23, 2019
Summary: Between invalidating a bridge and suspending its JS thread, native modules may have their methods called. Only warn when a native module has been invalidated, which happens right before its JS thread is suspended. Avoid initializing a native module's instance if its bridge is invalidated. /cc fkgozali facebook@f945212#commitcomment-32467567 [iOS] [Fixed] - Properly validate JS->native method calls Pull Request resolved: facebook#23658 Differential Revision: D14287594 Pulled By: fkgozali fbshipit-source-id: 89dd1906a0c55f3f48ba4ff220aac0cddf2eb822 # Conflicts: # React/CxxModule/RCTNativeModule.mm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Between invalidating a bridge and suspending its JS thread, native modules may have their methods called.
Only warn when a native module has been invalidated, which happens right before its JS thread is suspended.
Avoid initializing a native module's instance if its bridge is invalidated.
/cc @fkgozali f945212#commitcomment-32467567
Changelog
[iOS] [Fixed] - Properly validate JS->native method calls
Test Plan
N/A